Sanitize full path to support Windows #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Yes, we can merge this. Before merging, please:
sanitizeFullPath(path){
// Path Normalization for Windows - e.g "C:\\Users\\name\\file.txt" - "/Users/name/file.txt"
return path.replace(/^[A-Z]:/, "").replace(/\\/g, "/")
}
getFullPath(){
return this.sanitizeFullPath(resolve(cwd(), ...args))
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I have used this change in the past to collaborate with developers on Windows. I wonder if we can merge it upstream so I don't have to keep using my fork.
Please let me know if I need to do anything else